Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(katana): remove ContractInfoProvider #1943

Merged
merged 2 commits into from
May 9, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented May 8, 2024

Description

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

@kariy
Copy link
Member Author

kariy commented May 8, 2024

@kariy kariy mentioned this pull request May 8, 2024
10 tasks
@kariy kariy changed the title remove contract info provider refactor(katana): remove ContractInfoProvider May 8, 2024
@kariy kariy marked this pull request as ready for review May 8, 2024 21:52
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.42%. Comparing base (5a7ecd8) to head (340f648).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1943      +/-   ##
==========================================
+ Coverage   69.38%   69.42%   +0.04%     
==========================================
  Files         314      314              
  Lines       35391    35370      -21     
==========================================
+ Hits        24555    24556       +1     
+ Misses      10836    10814      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy
Copy link
Member Author

kariy commented May 9, 2024

Merge activity

  • May 9, 4:27 PM EDT: @kariy started a stack merge that includes this pull request via Graphite.
  • May 9, 4:27 PM EDT: @kariy merged this pull request with Graphite.

@kariy kariy merged commit 810cd57 into main May 9, 2024
15 checks passed
@kariy kariy deleted the refactor/remove-contract-info-provider branch May 9, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant